Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SG-37203 [Mockgun] ignore duplicate entities when multi_entity_update_mode is add #356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

SG-37203 [Mockgun] ignore duplicate entities when multi_entity_update_mode is add #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion shotgun_api3/lib/mockgun/mockgun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,7 +831,10 @@ def _update_row(self, entity_type, row, data, multi_entity_update_modes=None):
update_mode = multi_entity_update_modes.get(field, "set") if multi_entity_update_modes else "set"

if update_mode == "add":
row[field] += [{"type": item["type"], "id": item["id"]} for item in data[field]]
for item in data[field]:
new_item = {"type": item["type"], "id": item["id"]}
if new_item not in row[field]:
row[field].append(new_item)
elif update_mode == "remove":
row[field] = [
item
Expand Down
3 changes: 2 additions & 1 deletion tests/test_mockgun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,9 @@ def test_update_add(self):
"""
Ensures that "add" multi_entity_update_mode works.
"""
# _version2 already exists on the playlist and should not be duplicated
self._mockgun.update(
"Playlist", self._add_playlist["id"], {"versions": [self._version3]},
"Playlist", self._add_playlist["id"], {"versions": [self._version2, self._version3]},
multi_entity_update_modes={"versions": "add"}
)

Expand Down
Loading