Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for connecting to Shotgun via a proxy server #47

Merged
merged 3 commits into from
Nov 11, 2016

Conversation

kporangehat
Copy link

Adds a new proxy_server config setting. Accepts values in the standard Shotgun API format of 111.222.333.444:8080. If it’s empty, no proxy server will be used when connecting to Shotgun.

Also, default to using Python binary specified by environment instead of hardcoding the location to /usr/bin/python

KP added 2 commits November 11, 2016 13:54
Adds a new proxy_server config setting. Accepts values in the standard Shotgun API format of 111.222.333.444:8080. If it’s empty, no proxy server will be used when connecting to Shotgun.
@pboucher
Copy link

Each plugin also has its own Shotgun connection that probably needs proxy access as well. ~line 767.

Copy link

@pboucher pboucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pboucher pboucher merged commit 0386598 into master Nov 11, 2016
@pboucher pboucher deleted the proxy_server branch November 11, 2016 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants