SG-15210 Python3 port

[eshokrgozar]

Fixes to make the tool work with Python3.

[jfboismenu]

instanceof(value, six.text_type)

is the cleaner way to check for this. When we clean up our code in the long future where Python 2 is not supported anymore finding checks for six.text_type will be super easy.

[eshokrgozar]

I thought about doing this. There's an inconsistency in the way the argument type validation is done across the different plugins. Most of them use the type.__name__ like this (look at the values under the type key):

shotgunEvents/src/examplePlugins/update_timecode_from_frames.py

Lines 62 to 66 in 6d0ec8d

	args_to_check = {
	"source_frames_field": {"sg_type": "number", "type": "str"},
	"target_tc_field": {"sg_type": "timecode", "type": "str"},
	"fps": {"type": "float"},
	}

shotgunEvents/src/examplePlugins/update_timecode_from_frames.py

Lines 81 to 87 in 6d0ec8d

	value_type = type(args[name]).__name__
	# We assume unicode and str to be equivalent for these checks because
	# args come back from Django as unicode but are first set by the
	# Registrar as str.
	if value_type == "unicode":
	value_type = "str"

And a couple of them use the type itself:

shotgunEvents/src/examplePlugins/update_task_template_entities.py

Lines 67 to 81 in 6d0ec8d

	args_to_check = {
	"project_ids": {"type": [list], "allow_empty": False},
	"entity_types": {"type": [list], "allow_empty": False},
	"plugins_field": {
	"type": [str],
	"allow_empty": False,
	"entity": "TaskTemplate",
	"sg_type": ["list", "entity_type"],
	"required_values": ["N/A", args["plugins_field_value"]],
	},
	"plugins_field_value": {"type": [str], "allow_empty": False},
	"trash_old_tasks": {"type": [bool], "allow_empty": False},
	"overwrite_field_values": {"type": [bool], "allow_empty": False},
	"exclude_fields": {"type": [list], "allow_empty": True},
	}

I decided to do the string compare to keep it consistent with the other ones. I have no problem changing it to the isinstance method. But I did want to point this out to see if you think we should change all the other ones to not use the string matching either.

[jfboismenu]

Better is the enemy of good. If this is the pattern used in the repo, let's not rock the boat.

[jfboismenu]

Looks good to me! I only have two suggestions.

• please add a requirements.txt and update the README.md (or maybe the Wiki?). We now have a dependency on six.
• please use isinstance as mentioned in the comments.

[jfboismenu]

Looks good to me!