Fix #84, bad args on traceback.format_exc() calls #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkvertex
force-pushed
the
fix_format_exc_calls
branch
from
130a7fe to
72d7255
Compare
…n3 and silently do nothing in Python2. (Fixes shotgunsoftware#84)
darkvertex
force-pushed
the
fix_format_exc_calls
branch
from
72d7255 to
27743dd
Compare
|
(Just rebased and ran "black" to satisfy your CI's checks.) @mathurf Hi! I see you work at Autodesk and were this repo's last merged pull request's reactive reviewer, so I'm tagging your name. Sorry if it's rude of me. (Github won't let me add any reviewers to the PR the formal way.) These three lines never worked to begin with, but worse, they actually fail the process outright under Python 3. Please consider merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They break in Python3 and silently do nothing in Python2.
Fixes #84