Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when context entity "name" not cached #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

j0yu
Copy link

@j0yu j0yu commented Mar 10, 2021

From wwfxuk#7

Fixed

  • Missing context "name" when not found from path cache
Traceback (most recent call last):
  File "/path/to/tk-framework-qtwidgets.git/v2.9.3/python/context_selector/context_widget.py", line 638, in _on_entity_activated
    self._on_context_activated(context)
  File "/path/to/tk-framework-qtwidgets.git/v2.9.3/python/context_selector/context_widget.py", line 629, in _on_context_activated
    self._show_context(context)
  File "/path/to/tk-framework-qtwidgets.git/v2.9.3/python/context_selector/context_widget.py", line 846, in _show_context
    link_display = _get_link_display(context)
  File "/path/to/tk-framework-qtwidgets.git/v2.9.3/python/context_selector/context_widget.py", line 908, in _get_link_display
    entity_name = entity["name"]
KeyError: 'name'

This can happen when the folders for an entity have not been created yet via tank folder, or if there's something wrong with path cache synchronisation.

The fix focuses on making sure the GUI does not break under these circumstances.

@zavinator
Copy link

Why this fix is still not merged into master?
The standalone publisher can't be used (because of this bug) for example for linking with CustomEntity that has no work files (so it is not cached)...

@zavinator
Copy link

it is fixed since v2.10.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants