Tweaks to NoteInputDialog #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manneohrstrom
commented
Sep 22, 2016
| """ | ||
| def __init__(self, *args, **kwargs): | ||
| def __init__(self, parent): |
There was a problem hiding this comment.
This is how we do it everywhere else in the code. I think in general, we should try to avoid the *args, **kwargs open syntax unless we have reason to use it. It can make it trickier to make changes in the future - say for example we wanted to add some parameters to this method in the future.
manneohrstrom
commented
Sep 22, 2016
| """ | ||
| Constructor. |
There was a problem hiding this comment.
minor: this was looking odd in the sphinx docs!
|
We have something similar here - do you think it would be worth trying to consolidate the two? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the docs for the
NoteInputDialog.Changed the constructor to not be open but rather specific in order to make it easier to handle future changes to the interface.