Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate redis TLS certs at test time #588

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Mar 29, 2022

This makes progress towards #538

Uses https://github.com/est31/rcgen to generate the certs without a dependency on openssl
Although we could get away with using openssl I would like to move to rustls one day so better to use pure rust solutions where possible.

The generated certs end up a little different to those originally generated by https://github.com/redis/redis/blob/unstable/utils/gen-test-certs.sh
Here we have the difference between the old and new redis.crt
image
I tried to make it use the same RSA 256 algorithm previously used but rcgen does not support that yet due to: briansmith/ring#219

But the modified tests continue to pass so I dont see any problem with using a different algorithm.

To be done in follow up PRs:

  • rename redis-tls/tls_keys -> redis-tls/certs to match the naming scheme used by cassandra
  • generate cassandra certs at test time

But they are low priority, I was only working on this last week due to being blocked on other work.

Copy link
Member

@conorbros conorbros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one comment, LGTM.

@conorbros conorbros enabled auto-merge (squash) March 31, 2022 00:26
@conorbros conorbros merged commit 01dde88 into shotover:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants