Skip to content
This repository has been archived by the owner on Nov 4, 2020. It is now read-only.

containDeep erroneously passes when comparing array with a string value to a string value within object #157

Closed
seongju opened this issue Oct 16, 2017 · 1 comment · May be fixed by rona-dinihari/node-tesseract#7
Closed

containDeep erroneously passes when comparing array with a string value to a string value within object #157

seongju opened this issue Oct 16, 2017 · 1 comment · May be fixed by rona-dinihari/node-tesseract#7

Comments

@seongju
Copy link

seongju commented Oct 16, 2017 •
edited
Loading

I think I may have stumbled across a bug using containDeep.
screen shot 2017-10-16 at 11 33 12 am

According to the documentation, it seems that containDeep should have failed this assertion because for an object...

it checks that the same keys contain deep equal values (recursive)

Node.js version?

8.1.4

Should.js version?

11.2.1

How to reproduce it?

See above screenshot.
@btd
Copy link
Member

btd commented Oct 28, 2017

Yep, looks like a bug to me

@btd btd closed this as completed in 6a7989f Oct 28, 2017
btd added a commit that referenced this issue Oct 28, 2017
@btd
Merge pull request #159 from shouldjs/fix-157
1e7b1d0 
Fix #157
@rona-dinihari rona-dinihari mentioned this issue Oct 24, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade should from 2.1.1 to 13.2.3 rona-dinihari/node-tesseract
2 participants
@btd @seongju