Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollIndicatorInsets to ListView component #493

Conversation

majaklajic
Copy link
Contributor

Added scrollIndicatorInsets to ListView component. It forces scrollbar to be rendered correctly:
facebook/react-native#26610 (comment)

I've applyed the fix for iOS 13 only

This was my initial PR: https://github.com/shoutem/mobile/pull/94

Copy link
Collaborator

@Definitely-Not-Vlad Definitely-Not-Vlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, appreciate that you singled out the iOS platform version too. Sorry for missing this PR earlier today when I was meant to check for PR's, I always forget to check the UI repository.

@majaklajic majaklajic merged commit 6d8a04d into develop Jun 15, 2020
@majaklajic majaklajic deleted the feature/SEEXT-7594-only-iOS-software-13-devices-from-X-series]-scrollView-element-is-defected branch June 15, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants