fix(#272, 696fd52): Boilers respect the selected input temperature again. #273
Conversation
…ture again. When used as inputs to be boiled, fluids with multiple temperatures were treated as if they were already at their maximum temperature.
shpaass
force-pushed
the
272-py-incorrect-numbers-for-oil-burner
branch
from
4d7052a
to
3f5b4e6
Compare
|
Rebased on fresh master |
| @@ -120,7 +121,7 @@ public static RecipeParameters CalculateParameters(RecipeRow row) { | |||
| var fluid = recipe.ingredients[0].goods.fluid; | |||
| if (fluid != null) { | |||
| float inputTemperature = fluid.temperature; | |||
| foreach (Fluid variant in fluid.variants ?? []) { | |||
There was a problem hiding this comment.
Just for better understanding what the problem was and how that line solves it, could you please explain it to us?
There was a problem hiding this comment.
row.variants contains the variants selected for the recipe row (usually fluid ingredient temperatures, but sometimes an accumulator), while fluid.variants contains all possible temperatures for that fluid. This change restores the behavior of searching the temperatures selected for this row, instead of the possible temperatures for the input fluid.
|
I don't remember if it's the intended behavior, so I wanted to note it here: |
When used as inputs to be boiled, fluids with multiple temperatures were treated as if they were already at their maximum temperature.
In addition to the new test, I also confirmed that the boiler mechanics for pY showed the same number of buildings for each input temperature here as they did in 0.8.1.