-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pin cpu platform #302
base: master
Are you sure you want to change the base?
Conversation
d6aa899
to
6ba48d1
Compare
As none of us are proficient in the |
And to why we removed Any CPU: Obvious to get rid of the warning. But more precise, we import DLLs that are only comnpatible with specific platforms, by setting the platform on the project build, we make dotnet check for this platform requirement at startup rather than crash when it tries to load an incompatible dll. Note this wont actually change what's build otherwise, the resulting dotnet code is still platform independent. |
Thank you for the explanation! I guess that the next step of the review would be to figure out why the CI check fails and what we need to do about it. |
By the look, the CI test run the wrong platform. Let me see if i can update the CI commands. |
6a602a2
to
b4f5422
Compare
Yay, that took a few more tries than i would like to admit. First needed to find the right file, then the right command. Anyway i think i got it since the CI check is now green. I've rebased and squashed all changes into one commit. |
fixes shpaass#299 Move from any cpu to specific platforms since we use dlls that do not support any cpu. Set build script to specific platforms. Set github action: dotnet test to x64 specifically since arm64 wont run on github.
I might be wrong, but the criterion of #299 being fixed is that when you run This line is still present with the current PR. |
This should fix the
error. It was present for me when i started working on this, and gone after these changes. However right now i do not get that error anymore at all, both on master or my branch. I'm also not getting any other errors from |
That's curious because I still get this error on your branch. |
fixes #299
This sets our builds to the specific platform the dlls we ship.
We could support more platforms, but that would require us to include different dlls. This pr focus just on removing the warning about the architecture missmatch (any cpu) and the dlls we use.