Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
When upgrading the dependency spec to include v8, some python tests broke (see jupyter#1728). The tests were failing with a timeout due to indefinitely blocked IO. This originates in an infinitely-looping notebook and is caused by a misconfiguration of the client connection. Currently using `nbclient.NotebookClient` with a `jupyter_client.manager.KernelManager` results in a deadlock. nbclient doesn't seem aware of this issue because there is no test covering it. `NotebookClient` uses `AsyncKernelManager` by default. So why isn't nbgrader using it? nbgrader uses the NotebookClient via nbconvert which just realized the same issue. Up until v7.3.1, nbconvert has been hard-coding the default kernel manager to the sync version. (see jupyter/nbconvert#1964) Rather than require nbconvert>=7.3.1, this commit sets our own default value to the async kernel manager.
- Loading branch information