Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHRINKRES-322] Resolve declaration redundancy #186

Merged
merged 2 commits into from
Mar 4, 2024
Merged

[SHRINKRES-322] Resolve declaration redundancy #186

merged 2 commits into from
Mar 4, 2024

Conversation

petrberan
Copy link
Member

@petrberan petrberan requested a review from xstefank November 30, 2023 13:09
xstefank
xstefank requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@xstefank xstefank left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misclick, this review is wrong

@xstefank xstefank self-requested a review January 31, 2024 09:25
xstefank
xstefank approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally convinced this kind of fixes need a separate issues but ok.

@petrberan petrberan merged commit 53e3aae into shrinkwrap:master Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xstefank xstefank xstefank approved these changes

Assignees
No one assigned
Labels
needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrberan @xstefank