[SHRINKRES-336] Add missing impl-gradle dependency #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrberan
reviewed
Apr 30, 2024
README.asciidoc
Outdated
| @@ -19,6 +19,7 @@ ShrinkWrap Resolvers is comprised of the following modules: | |||
| |Maven Implementation with Archive Integration|org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven-archive | |||
| |Embedded Gradle API|org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-api-gradle-embedded-archive | |||
| |Embedded Gradle Implementation with Archive Integration|org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-gradle-embedded-archive | |||
| |Implementation for Gradle Dependency Resolution|org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-gradle | |||
There was a problem hiding this comment.
No need to add that. There are already modules missing and I would rather prefer this section gone as part of the https://issues.redhat.com/browse/SHRINKRES-338
xjusko
force-pushed
the
add-missing-dependency-in-gradle-depchain
branch
2 times, most recently
from
8ac9834 to
1d7eb86
Compare
xjusko
force-pushed
the
add-missing-dependency-in-gradle-depchain
branch
from
1d7eb86 to
be194c8
Compare
xjusko
force-pushed
the
add-missing-dependency-in-gradle-depchain
branch
from
be194c8 to
1870f83
Compare
xjusko
changed the title
petrberan
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/SHRINKRES-336