Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce alloc in filtering/unfiltering by reusing buffers #191

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Reduce alloc in filtering/unfiltering by reusing buffers #191

merged 2 commits into from
Sep 4, 2019

Conversation

SethDusek
Copy link
Contributor

No description provided.

@shssoichiro
Copy link
Owner

Thanks! Time difference is in the noise, but peak memory usage looks to be down about 5%.

@shssoichiro shssoichiro merged commit 68b763b into shssoichiro:master Sep 4, 2019
@SethDusek
Copy link
Contributor Author

Thanks! Time difference is in the noise, but peak memory usage looks to be down about 5%.

I was meaning to talk about that but got kinda caught up. It seems that perf is reporting more "page faults" with this patch as compared to before. I'm not sure why this is, but it'll take a deeper investigation most probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shssoichiro shssoichiro shssoichiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SethDusek @shssoichiro