-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality in mp/mps/mpo and add ExpDVR basis #155
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 84.79% 84.30% -0.50%
==========================================
Files 105 105
Lines 10183 10355 +172
==========================================
+ Hits 8635 8730 +95
- Misses 1548 1625 +77
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me : )
The test coverage is too low currently - it seems easy to add a few tests for these new functions |
I will add doc and tests later. |
I close the PR now and will open it again when the new features for nuclear dynamics are ready. |
mps.add([mps1, mps2,....])
Mpo.from_mps()
Mps.from_mpo()