Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stacked qc mpo for larger scale qc calculation #163

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

jiangtong1000
Copy link
Collaborator

This PR is a follow up of #154
Could improve the qc speed. The qc mpo is added by N smaller mpos with bond dim of O(N).

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (b10fcaf) 84.82% compared to head (d24e8c9) 84.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   84.82%   84.84%   +0.01%     
==========================================
  Files         105      105              
  Lines       10207    10232      +25     
==========================================
+ Hits         8658     8681      +23     
- Misses       1549     1551       +2     
Files Changed Coverage Δ
renormalizer/model/h_qc.py 98.30% <100.00%> (+0.28%) ⬆️
renormalizer/mps/tests/test_gs.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liwt31
Copy link
Collaborator

liwt31 commented Sep 21, 2023

Looks great! Is it reported in the literature? And how fast is it for typical cases?

@liwt31 liwt31 merged commit 2044db8 into master Sep 21, 2023
5 checks passed
@liwt31 liwt31 deleted the stacked_qcmpo branch September 21, 2023 02:27
@jiangtong1000
Copy link
Collaborator Author

Looks great! Is it reported in the literature? And how fast is it for typical cases?

yea I think this is a well known trick, see Eq 6 of (https://arxiv.org/abs/1703.04789)

@jiangtong1000
Copy link
Collaborator Author

@liwt31 I did not test with typical systems yet, but in principle I think it can speed up N times? if we consider the step of updating the Environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants