[v3] remove aria-hidden attr when scroll-to-top button is visible (#3251

) * [v3] remove aria-hidden attr when scroll-to-top button is visible * Update packages/nextra-theme-docs/src/components/back-to-top.tsx --------- Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
shuding · Sep 16, 2024 · bf963cd · bf963cd
1 parent cee94a6
commit bf963cd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/few-snails-occur.md b/.changeset/few-snails-occur.md
@@ -0,0 +1,5 @@
+---
+'nextra-theme-docs': patch
+---
+
+Remove the aria-hidden attribute from scroll-to-top button when it is visible
diff --git a/packages/nextra-theme-docs/src/components/back-to-top.tsx b/packages/nextra-theme-docs/src/components/back-to-top.tsx
@@ -26,7 +26,8 @@ export function BackToTop({
 }): ReactElement {
   return (
     <Button
-      aria-hidden="true"
+      // elements with `aria-hidden: true` must not be focusable or contain focusable elements
+      aria-hidden={hidden ? 'true' : undefined}
       onClick={scrollToTop}
       disabled={hidden}
       className={({ disabled }) =>