Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom label for back-to-top link #2895

Closed
wants to merge 6 commits into from

Conversation

xijinping0
Copy link

@xijinping0 xijinping0 commented May 21, 2024

This PR resolves #2308 by adding a backToTopLabel field to the toc config.

I have confirmed in examples/docs that this change is working locally. The label is set to Go back to top please in the screenshot:

Screen Shot 2024-05-21 at 00 16 22

Thank you in advance for your review.

Copy link

changeset-bot bot commented May 21, 2024

⚠️ No Changeset found

Latest commit: cc18f3a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 7:33am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 7:33am

Copy link

vercel bot commented May 21, 2024

@xijinping0 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@xijinping0 xijinping0 marked this pull request as ready for review May 21, 2024 07:31
@xijinping0 xijinping0 changed the title support custom label for back-to-top support custom label for back-to-top link May 21, 2024
Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I am not plan to add more features in v2, use v3 as base branch

@dimaMachina
Copy link
Collaborator

superseded by #3258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n support for Scroll to top
2 participants