Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): add fallback bg-color for search result #363

Merged
merged 2 commits into from
Mar 5, 2022
Merged

fix(search): add fallback bg-color for search result #363

merged 2 commits into from
Mar 5, 2022

Conversation

neighborhood999
Copy link
Contributor

@neighborhood999 neighborhood999 commented Feb 16, 2022

Screenshots

Firefox

Light Dark
Screenshot 2022-02-17 at 14-10-30 React Hooks for Data Fetching – SWR Screenshot 2022-02-17 at 14-10-15 React Hooks for Data Fetching – SWR

Safari

Light Dark
截圖 2022-02-17 下午2 09 29 截圖 2022-02-17 下午2 09 40

Description

Hi @shuding, thank you for creating an amazing static site generator.

I found a little style issue on the search result and try to fix it, not sure change is good or not, feel free to give me any suggestions, thank you.

Signed-off-by: Jie Peng im@jiepeng.me

Signed-off-by: Jie Peng <im@jiepeng.me>
@vercel
Copy link

vercel bot commented Feb 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shuding/nextra/GWsyeLcDBLb8brzaECkJAeAUxXfo
✅ Preview: Canceled

[Deployment for cba5e6d canceled]

@shuding
Copy link
Owner

shuding commented Feb 16, 2022

Thanks for your PR! But it does show the opacity and backdrop blur for me… maybe we should have a way to fallback.

@shuding
Copy link
Owner

shuding commented Feb 16, 2022

@neighborhood999
Copy link
Contributor Author

I use Firefox as the main browser and now I understand it still does not support backdrop-fitler...
Let me take the time to figure out any solution, I'm not familiar with Tailwind CSS haha.

Signed-off-by: Jie Peng <im@jiepeng.me>
@neighborhood999
Copy link
Contributor Author

Hi @shuding:

I added Firefox and Safari browser comparison screenshots, it works for me, anything needs to adjust feel free to let me know, thank you.

@neighborhood999 neighborhood999 changed the title fix(search): remove ul bg opacity fix(search): add fallback bg-color for search result Feb 17, 2022
@shuding
Copy link
Owner

shuding commented Mar 5, 2022

Thank you @neighborhood999 and sorry for the delay! The fix looks great to me now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants