Add minimal go.mod, go.sum. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention is to make it so that it's possible to import and use this package from within Go modules (in addition to the well-supported GOPATH workspace mode), and have it build without users having to manually specify that github_flavored_markdown requires blackfriday v1. Use the recently created blackfriday v1.5.2 tag. Only specify the blackfriday version in go.mod and go.sum; others are unspecified to avoid the added burden of maintaining and updating them. Fixes #12. Closes #20.
|
I do not have hands-on experience with modules yet, but from what I've read, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to make it so that it's possible to import and use this package from within Go modules (in addition to the well-supported GOPATH workspace mode), and have it build without users having to manually specify that github_flavored_markdown requires blackfriday v1.
Use the recently created blackfriday v1.5.2 tag.
Only specify the blackfriday version in go.mod and go.sum; others are unspecified to avoid the added burden of maintaining and updating them.
Updates #12.
Updates #20.
/cc @markbates @rtfb @bep