Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gtk3 HiDPI: menus #326

Open
DarthGandalf opened this issue May 8, 2021 · 7 comments
Open

Gtk3 HiDPI: menus #326

DarthGandalf opened this issue May 8, 2021 · 7 comments
Labels
bug Something isn't working gtk3 regression

Comments

@DarthGandalf
Copy link
Member

Brief summary of issue

Wrong parts of screen are taken

Steps to reproduce the issue

  1. export GDK_SCALE=2
  2. Try to take picture of menus (with nested/cascaded submenus), or a section of a window
  3. See that the result doesn't look right:

Menu_004

Error output

Extra information, such as Shutter version, operating system and ideas for how to solve:

Linux, Shutter version with #284 merged.

@DarthGandalf DarthGandalf added the bug Something isn't working label May 8, 2021
DarthGandalf added a commit to DarthGandalf/shutter that referenced this issue May 8, 2021
@Photon89
Copy link
Member

Photon89 commented May 8, 2021

Subwindows actually stopped working a long time ago, so the reason is not in the recent changers (after 0.94), here's a (very old) report: #25 Menus and submenus are working in 0.95. But I think, the breakage is not a major thing compared to the progress made since 0.95. If it turns out to be a hard nut to crack, maybe just remove the corresponding button and menu entries for the time being?

@DarthGandalf
Copy link
Member Author

@Photon89 thanks for link. I agree that it may be removed.

Menus is a different case. They work fine in 0.94.

@Photon89
Copy link
Member

Photon89 commented May 8, 2021

Agreed. Though, if the menus bug is hard to fix with the changes made after 0.95, I think it would be fine to remove them as well, temporarily.

I am currently trying to run the latest git commit, need to package perl-gtk3-imageview-8 and, possibly, other deps first though.

@DarthGandalf
Copy link
Member Author

The current workaround I made for the menus bug is to show the warning with the advice to disable scaling. I think it's better than removing the feature altogether.

@Photon89
Copy link
Member

Photon89 commented May 8, 2021

I see, I missed the part where you said that the bug only appears on HiDPI setups. Then your solution is much better than just removing the functionality completely.

@DarthGandalf DarthGandalf changed the title Gtk3 HiDPI: menus and window sections Gtk3 HiDPI: menus May 8, 2021
@DarthGandalf
Copy link
Member Author

I've disabled the sections buttons

@DarthGandalf
Copy link
Member Author

To clarify: this was not a problem in 0.95 because gtk 2 doesn't have a concept of automatic UI scaling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gtk3 regression
Projects
None yet
Development

No branches or pull requests

2 participants