-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add resources and services to workspace #1017
Conversation
a1dddda
to
3c4361f
Compare
|
32e4665
to
46d8c5f
Compare
ac77b37
to
a05f064
Compare
Turso is also excluded, a comment in the root toml explains why. |
SQLX 0.7 is released, which should solve the turso thing, but that is a bigger job for a different PR. |
Cargo.toml
Outdated
shuttle-codegen = { path = "codegen" } | ||
shuttle-common = { path = "common" } | ||
shuttle-proto = { path = "proto" } | ||
shuttle-service = { path = "service" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oddgrd Do you think removing the versions here will break something in the release process? I'm down to just "if it ain't broke, don't fix it" and add them back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we would need the versions to be able to publish the crates that use these. You should be able to test this with cargo publish --dry-run
in one of the crates.
b00bbf9
to
55782bf
Compare
When I tried to
...which might not be our issue, but these kinds of things increase in probability if we jam more and more packages into the workspace 😕. I think we should be careful about the decision to merge this. |
55782bf
to
6a4dd69
Compare
Yes, we have stumbled upon this hidden treasure in the rust ecosystem before. 😅 I agree that we should be careful merging this, since the advantage of doing so is not that significant either (correct me if I'm wrong). The PR has also grown quite large, perhaps we should rather split it up, merge the easy wins, and then re-consider how we will handle services and resources in the workspace in the future? |
The only easy wins I see are small CI improvements and the extended feature flags on aws-rds. Can be done but not very significant. |
Description of change
How has this been tested? (if applicable)