Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge runtime updates in main ecs branch #1709

Merged
merged 10 commits into from
Apr 2, 2024

Conversation

oddgrd
Copy link
Contributor

@oddgrd oddgrd commented Apr 2, 2024

Description of change

This adds a healthcheck to the runtime, as well as some logic we can use to ensure the runtime shuts down if it doesn't start the service within a certain timeframe. The logic to make the runtime handle failure well will need some further iteration in the future, since there are a few ways having it as a server that is called by the runner sidecar can lead to failures.

This also changes the runtime to start on the unspecified IP, which is necessary in the new architecture, but the current platform should still use localhost.

How has this been tested? (if applicable)

These changes have been tested on the headroom stack on their own, alongside changes in ecs-shuttle and shuttle-aws.

Copy link
Contributor

@iulianbarbu iulianbarbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@oddgrd oddgrd merged commit e40002b into feat/shuttle-ecs-common Apr 2, 2024
29 of 32 checks passed
iulianbarbu pushed a commit that referenced this pull request Apr 11, 2024
* feat: runtime healthcheck, start runtime on 0.0.0.0

running on unspecified ip was necessary for the runner to be able to reach the runtime when they are running in separate containers

* feat(proto): update runtime::get_client to work with

* misc(proto): get client takes u16 port

* feat: add health toggle to runtime

* feat: set runtime to unhealthy if it doesn't start within 60s

* feat: change runtime::get_client to take address

* feat: kill runtime if it doesn't become healthy in time

* feat: increase provisioning timeout duration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants