Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: allow deprecated chrono method in deprecated backends #1905

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

jonaro00
Copy link
Member

No description provided.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses deprecation warnings in the logger and proto modules by allowing the use of deprecated chrono methods in deprecated backends.

  • Added #[allow(deprecated)] attribute in logger/src/dal.rs for NaiveDateTime::from_timestamp_opt in from_log_item function
  • Added #[allow(deprecated)] attribute in proto/src/lib.rs for from_timestamp_opt method in the logger module
  • These changes are temporary solutions for deprecated backends, but future updates to non-deprecated alternatives should be considered

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@jonaro00 jonaro00 merged commit 0b3f714 into shuttle-hq:main Oct 10, 2024
6 of 25 checks passed
@jonaro00 jonaro00 deleted the nit/clippy branch October 10, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant