Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flag for router IP local run #565

Merged
merged 13 commits into from
Jan 10, 2023
Merged

feat: add flag for router IP local run #565

merged 13 commits into from
Jan 10, 2023

Commits on Jan 4, 2023

  1. feat: add flag for router IP local run

    @joshua-mo-143
    joshua-mo-143 committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    47b619b View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. refactor: amend ipaddr setting, local run init fn

    @joshua-mo-143
    joshua-mo-143 committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    f43e2e5 View commit details
    Browse the repository at this point in the history

  2. refactor: delete unnecessary dependency 

    Forgot to delete a dependency and it looks like I can't squash commits, whoops 🤦
    @joshua-mo-143
    joshua-mo-143 committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    1794cc6 View commit details
    Browse the repository at this point in the history

  3. Revert "refactor: delete unnecessary dependency" 

    This reverts commit 1794cc6.
    @joshua-mo-143
    joshua-mo-143 committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    288b0f7 View commit details
    Browse the repository at this point in the history

  4. refactor: remove unnecessary dep (amendment) 

    Re-pushing this amendment but without the git diff. Probably should have changed that before submitting initially.
    @joshua-mo-143
    joshua-mo-143 committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    cabab8c View commit details
    Browse the repository at this point in the history

  5. clippy

    @joshua-mo-143
    joshua-mo-143 committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    b8fe057 View commit details
    Browse the repository at this point in the history

  6. amendment from clippy warning (needless borrow)

    @joshua-mo-143
    joshua-mo-143 committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    20da60e View commit details
    Browse the repository at this point in the history

  7. refactor: apply cargo fmt diffs

    @joshua-mo-143
    joshua-mo-143 committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    b00e9e2 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. refactor: return URL from run test setup fn 

    + cargo_shuttle_run() now returns a string containing the full base URL instead of port
+ Relevant changes have been made to tests to account for this
    @joshua-mo-143
    joshua-mo-143 committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    5471e66 View commit details
    Browse the repository at this point in the history

  2. refactor: change flag name to be 'external' 

    Changed as per discussion on the PR.
    @joshua-mo-143
    joshua-mo-143 committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    127fb5f View commit details
    Browse the repository at this point in the history

  3. refactor: use passed args directly for struct

    @joshua-mo-143
    joshua-mo-143 committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    75c2895 View commit details
    Browse the repository at this point in the history

  4. test: make sure tests align to proper folders

    @joshua-mo-143
    joshua-mo-143 committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    1df901a View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Merge branch 'main' into main

    @oddgrd
    oddgrd authored Jan 9, 2023
    Configuration menu
    Copy the full SHA
    d273426 View commit details
    Browse the repository at this point in the history