Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified setup.py and pyamgx/System.pyx. #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rwdlnk
Copy link

@rwdlnk rwdlnk commented Jan 9, 2024

Changes needed to successfully install pyamgx
on latest amgx install, Python3, and Ubuntu 22.04. Also corrected AMGX path for examples/FiPy/diffusion.py (changed core to src).

Changes needed to successfully install pyamgx
on latest amgx install, Python3, and Ubuntu 22.04
@@ -38,7 +38,8 @@
pyamgx.initialize()

from pyamgx_solver import PyAMGXSolver
with open (os.environ['AMGX_DIR']+'/core/configs/AMG_CLASSICAL_PMIS.json') as f:
#with open (os.environ['AMGX_DIR']+'/core/configs/AMG_CLASSICAL_PMIS.json') as f:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just delete this?

@@ -73,12 +77,19 @@
library_dirs = [
numpy.get_include(),
] + AMGX_lib_dirs,
<<<<<<< HEAD
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bad merge here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for replying. Yes, I think I did a gitdiff and it messed up my files. Let me look these files over and get back to you. I'll rename the "tests" directory as you suggested.

Rod

Copy link
Owner

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! For the examples, can we avoid the prefix test? I believe that will confuse pytest and it will attempt to run the module as if it contained unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants