Allow 2-parameter lambda_sampling #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sibirrer
requested changes
Feb 22, 2023
There was a problem hiding this comment.
Looks great @chinyitan, thank you very much!
Please add tests that cover your additions in the parameter handling, and in the feature that you introduced.
Also, you can add your name to the contributors ;)
| @@ -45,6 +46,8 @@ def __init__(self, kwargs_likelihood_list, cosmology, kwargs_bounds, sne_likelih | |||
| :param lambda_ifu_distribution: string, distribution function of the lambda_ifu parameter | |||
| :param alpha_lambda_sampling: bool, if True samples a parameter alpha_lambda, which scales lambda_mst linearly | |||
| according to a predefined quantity of the lens | |||
| :param beta_lambda_sampling: bool, if True samples a parameter beta_lambda, which scales lambda_mst linearly | |||
| according to a predefined quantity of the lens | |||
There was a problem hiding this comment.
can you describe a bit in more detail how and where this 'pre-defined quantity' gets described?
| @@ -199,7 +203,7 @@ def check_dist(self, kwargs_lens, kwargs_kin, kwargs_source): | |||
| return False | |||
|
|
|||
| def draw_lens(self, lambda_mst=1, lambda_mst_sigma=0, kappa_ext=0, kappa_ext_sigma=0, gamma_ppn=1, lambda_ifu=1, | |||
| lambda_ifu_sigma=0, alpha_lambda=0): | |||
| lambda_ifu_sigma=0, alpha_lambda=0, beta_lambda=0): | |||
There was a problem hiding this comment.
add documentation for beta_lambda
| @@ -89,6 +92,12 @@ def param_list(self, latex_style=False): | |||
| list.append(r'$\alpha_{\lambda}$') | |||
| else: | |||
| list.append('alpha_lambda') | |||
| if self._beta_lambda_sampling is True: | |||
| @@ -146,6 +155,12 @@ def args2kwargs(self, args, i=0): | |||
| else: | |||
| kwargs['alpha_lambda'] = args[i] | |||
| i += 1 | |||
| if self._beta_lambda_sampling is True: | |||
| @@ -182,4 +197,7 @@ def kwargs2args(self, kwargs): | |||
| if self._alpha_lambda_sampling is True: | |||
| if 'alpha_lambda' not in self._kwargs_fixed: | |||
| args.append(kwargs['alpha_lambda']) | |||
| if self._beta_lambda_sampling is True: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.