Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility update with GNFW #44

Merged
merged 9 commits into from
Sep 13, 2024
Merged

Conversation

williyamshoe
Copy link
Collaborator

@williyamshoe williyamshoe commented Sep 12, 2024

Updated the KinConstraintsComposite class so that it is compatible with Lenstronomy #650. KinConstraintsComposite now accepts alpha_Rs_array as input, or alternatively kappa_s_array or rho0_array.

@williyamshoe williyamshoe changed the title Compatibility updates with GNFW Compatibility update with GNFW Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.19%. Comparing base (f482350) to head (20c2f76).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   99.18%   99.19%           
=======================================
  Files          49       49           
  Lines        2583     2597   +14     
=======================================
+ Hits         2562     2576   +14     
  Misses         21       21           
Files with missing lines Coverage Δ
hierarc/LensPosterior/kin_constraints_composite.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@ajshajib ajshajib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @williyamshoe. I am requesting a minor variable name change for simplicity.

hierarc/LensPosterior/kin_constraints_composite.py Outdated Show resolved Hide resolved
hierarc/LensPosterior/kin_constraints_composite.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ajshajib ajshajib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one more small suggestion, after that it's good to be merged. Thanks again!

hierarc/LensPosterior/kin_constraints_composite.py Outdated Show resolved Hide resolved
@williyamshoe williyamshoe merged commit 5bc9cac into sibirrer:main Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants