Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files reported as exported in extraction record not 100% accurate. #11

Closed
siblount opened this issue Aug 26, 2022 · 2 comments · Fixed by #25
Closed

Files reported as exported in extraction record not 100% accurate. #11

siblount opened this issue Aug 26, 2022 · 2 comments · Fixed by #25
Assignees
Labels
bug Something isn't working verify fixed Verify that the issue was truly fixed.

Comments

@siblount
Copy link
Owner

The extraction record consists of a file list, which only holds files that were successfully extracted to the destination. However, I did run into an issue once installing a poser-formatted file structure where some of the files did not extract despite the extraction record indicating that it was.

It may be exclusive to poser-formatted file structures or it may be an issue with the logic in DPZipArchive or DPRARArchive.

@siblount siblount added the bug Something isn't working label Aug 26, 2022
@siblount
Copy link
Owner Author

siblount commented Aug 26, 2022

Found issue and working on a fix.

Issue occurred due to a folder down 4 levels from root was named "Scene", which is a common content folder (in other words, in the user's list of common content folders), and resulted in that being determined to be a content folder even though a more qualified content folder was populated. So technically, the extraction record was correct, the file was extracted but at an unexpected location within the user's destination path. I will update the extraction records soon as well.

For example, "My Product/Environments/My Name/Scene", would fail because of two reasons.

  1. "Scene"'s parent folder has isPartOfContentFolder and content folder set to false, which makes it eligible to be considered as a content folder.
  2. "Scene" is in the user's common content folder lists, which is a requirement to be considered as a content folder.

Because of this, the relative paths of the children of this folder were set to this folder, meaning that the calculated expected location would output: "D:/My Daz 3D Library/Scene", instead of (the correct path): "D:/My Daz 3D Library/Environments/My Name/Scene".

Additionally, it means there was a flaw w/ isPartOfContent logic that needs to be checked. Because technically, The "Environments" folder had isPartOfContentFolder set as true, which should've meant that "MyName" and "Scene"'s isPartOfContent would also set to true.

An upcoming solution now replaces the current code that goes from bottom of the tree up, to up to down, hopefully making isPartOfContent accurate.

@siblount siblount self-assigned this Aug 26, 2022
@siblount siblount added the verify fixed Verify that the issue was truly fixed. label Aug 27, 2022
@siblount
Copy link
Owner Author

I'm pretty sure this is fixed, but I (or along with someone else) need to start making tests to verify this issue was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verify fixed Verify that the issue was truly fixed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant