-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source code maintenance + bug fixes + features #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the issue where the zip archive file handle was not released even when done; call ReleaseArchiveHandles() at the end of ProcessArchive. Updated 7zArchive to kill the 7z process tree if it still exists.
try catch ReadMetaFiles, ReadContentFiles and others.
remove now ask for confirmation remove product is implemented and more advanced than the one on library item.
… helper funcs and proprogating changes across DPDatabase
…orm. Note: Doesn't successfully save.
…m finally, typo fixes
TableUpdated and ProductRecordModified() already invokes the event, no need for it twice.
Also removed FileName for DPAbstractArchive since it will be covered by DPAbstractFile.
…d to DAZ directory root folder. Added new CalculateChildRelativePath() and CalculateChildRelativeTargetPath() funcs for DPFolder. Added GetTargetPath() and propogated changes from DPFolder onto here for DPProcessor.
Anchored button and combobox to the right.
Replaced DPProgressCombo with an actual UserConrtol ProgressCombo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up the codebase to be a bit more modular, making it easier to test some components. Speaking of testing, we have a crap ton of tests to make sure things are running as expected!