Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify Input Payload Contracts #163

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Conversation

dagurval
Copy link

Identifies and extract payload from Input Payload Contract.

Screenshot 2021-08-31 at 15 10 26

We use this in VotePeer and we link to this explorer from the app. It would improve our app if this feature got accepted.

@dagurval
Copy link
Author

Example transaction: 8df4ac34150d38e408356b2c516188c571d311cbcba355de4e5e1e5fdd494527

@sickpig
Copy link
Owner

sickpig commented Oct 18, 2021

@dagurval sorry for the delay in reviewing the PR (I must have missed the notification), the code looks good to me and I 'm ready to merge and deploy.

I just noticed that getInputPayloadContractPayload() used two different chars for indentation, 1 tab or 4 spaces for 1 indent level.

In the past I kept the same way of indenting as the upstream project we have forked from just to ahve an easier way to do backport when needed, but I wouldn't mind accepting the 4 spaces indenting style as long as the indention style is consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants