Revert "Fix mempool summary views rendering" #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rostrum 9.0.0 and Fulcrum 1.9.X introduced a modification to blockchain.address.get_balance. The change is related to the activation of CashTokens on May 2023 An optional parameter has been added to get_balance, namely token_filter, so that in the calculated amount UTXOs associated to an address could be counted in or not on the base of their association to a toke. That lead to some kind of weird corner case where not all UTXOs got considered while computing the amount of a given address. The fix comes down to negotiate the proper protocol version between the explorer and the electrum server. In case of Rostrum 1.4 is the max proto version and the one that is needed to get a balance accounting for all UTXOs. For Fulcrum 1.9.x 1.5 is the right proto version (prior to that the get_balance is supposed to accept only 1 parameter).
That view rendering could pretty resource consuming when the address we are looking for has a very long transaction history. I'm going to temporarely add a rate limit for that view that take into account the number of requests for a given time interval by the same IP address. Once pagination would be provided by Eletrum servers (eg Rostrum) for the used methods (eg get_history) we could use it to reduce the amount of load anda data involved and we will be able to remove the rate limit on the page.
lozanopo
changed the base branch from
master
to
add-cross-check-to-transaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #170