Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary console.log #8

Closed
ryan-on-rails opened this issue Mar 24, 2015 · 4 comments
Closed

Unnecessary console.log #8

ryan-on-rails opened this issue Mar 24, 2015 · 4 comments

Comments

@ryan-on-rails
Copy link

Really great work. Used this directive really easily and it's also easy to customize.

I'm just wondering if it's necessary / expected to console log all of the articles once the feed loads? It's not causing any issues for my app, it's just distracting when I'm developing.

Really easy fix, just wondering if that was the intended behavior?

Thanks!
@siddii
Copy link
Owner

siddii commented Mar 24, 2015

Thanks for reporting. It's removed from the master a while ago. I guess, the dist scripts & other branches haven't been synced up properly.

@ryan-on-rails
Copy link
Author

No worries. Glad I could help!

@bropp
Copy link

bropp commented Apr 7, 2015

Ran into the same issue, looks like the commit to remove it from the source didn't update the minified/dist versions. Anyway we could get that removed? Willing to submit a pull request if given instruction as to how to recreate the files.

Thanks!

siddii added a commit that referenced this issue Apr 7, 2015
@siddii
Fixing for #8
953f6be
@siddii
Copy link
Owner

siddii commented Apr 7, 2015

Fixed in v0.0.4

@siddii siddii closed this as completed Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@siddii @bropp @ryan-on-rails