fix: keepalive interval calculation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should have been `max`, not `min`, enforcing minimum keepalive interval, not the other way around. Also update dependencies and rekres. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
commented
Mar 12, 2024
| @@ -276,7 +276,7 @@ func (client *Client) Run(ctx context.Context, logger *zap.Logger, notifyCh chan | |||
|
|
|||
| opts := []grpc.DialOption{ | |||
| grpc.WithKeepaliveParams(keepalive.ClientParameters{ | |||
| Time: min(10*time.Second, client.options.TTL/10), | |||
| Time: max(10*time.Second, client.options.TTL/10), | |||
utkuozdemir
approved these changes
Mar 12, 2024
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Mar 13, 2024
See siderolabs/discovery-client#9 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should have been
max, notmin, enforcing minimum keepalive interval, not the other way around.Also update dependencies and rekres.