fix: ensure servers always get patched #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy request for wonderful-swartz-a1308c pending review. Review with commit e372d82 https://app.netlify.com/sites/wonderful-swartz-a1308c/deploys |
|
/approve |
This PR fixes a bug encountered when pivoting clusters where we weren't updating in-use status on every reconcile loop. Statuses aren't copied over with a `clusterctl move`, so we need to make sure it gets updated. Signed-off-by: Spencer Smith <robertspencersmith@gmail.com>
andrewrynhard
approved these changes
Aug 20, 2020
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug encountered when pivoting clusters where we weren't
updating in-use status on every reconcile loop. Statuses aren't copied
over with a
clusterctl move, so we need to make sure it gets updated.