Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an option to mark PMBR as bootable (active) #3532

Closed
smira opened this issue Apr 26, 2021 · 0 comments · Fixed by #3680
Closed

add an option to mark PMBR as bootable (active) #3532

smira opened this issue Apr 26, 2021 · 0 comments · Fixed by #3680
Assignees
@Unix4ever
Milestone
0.11

Comments

@smira
Copy link
Member

smira commented Apr 26, 2021

Feature Request

Some ancient BIOSes can't read GPT, so they require MBR partition to be marked as bootable (active) to proceed with even booting from the hard disk.

Description

See siderolabs/go-blockdevice#33 which brought the change, but it was reverted.

Now we want to bring the change above as optional, and enable it via the machine.install. configuration flag.

cc @mzahorik
@smira smira added this to the 0.11 milestone Apr 26, 2021
@Unix4ever Unix4ever self-assigned this May 26, 2021
Unix4ever added a commit to Unix4ever/talos that referenced this issue May 26, 2021
@Unix4ever
feat: add ability to mark MBR partition bootable
dd73109 
Fixes: siderolabs#3532

Machine install section now has `markMBRBootable` option.

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
@Unix4ever Unix4ever mentioned this issue May 26, 2021
Merged
Unix4ever added a commit to Unix4ever/talos that referenced this issue May 26, 2021
@Unix4ever
feat: add ability to mark MBR partition bootable
ac7e121 
Fixes: siderolabs#3532

Machine install section now has `markMBRBootable` option.

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
Unix4ever added a commit to Unix4ever/talos that referenced this issue May 26, 2021
@Unix4ever
feat: add ability to mark MBR partition bootable
32bd977 
Fixes: siderolabs#3532

Machine install section now has `markMBRBootable` option.

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
Unix4ever added a commit to Unix4ever/talos that referenced this issue May 27, 2021
@Unix4ever
feat: add ability to mark MBR partition bootable
1fae37a 
Fixes: siderolabs#3532

Machine install section now has `markMBRBootable` option.

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
Unix4ever added a commit to Unix4ever/talos that referenced this issue May 27, 2021
@Unix4ever
feat: add ability to mark MBR partition bootable
cf1effc 
Fixes: siderolabs#3532

Machine install section now has `markMBRBootable` option.

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
Unix4ever added a commit to Unix4ever/talos that referenced this issue May 27, 2021
@Unix4ever
feat: add ability to mark MBR partition bootable
6b3ceb9 
Fixes: siderolabs#3532

Machine install section now has `markMBRBootable` option.

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
Unix4ever added a commit to Unix4ever/talos that referenced this issue May 27, 2021
@Unix4ever
feat: add ability to mark MBR partition bootable
8beb608 
Fixes: siderolabs#3532

Machine install section now has `markMBRBootable` option.

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
Unix4ever added a commit to Unix4ever/talos that referenced this issue May 27, 2021
@Unix4ever
feat: add ability to mark MBR partition bootable
db6b942 
Fixes: siderolabs#3532

Machine install section now has `markMBRBootable` option.

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
talos-bot pushed a commit that referenced this issue May 27, 2021
@Unix4ever @talos-bot
feat: add ability to mark MBR partition bootable
76dbfb3 
Fixes: #3532

Machine install section now has `markMBRBootable` option.

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Unix4ever Unix4ever

Labels
None yet
Projects
None yet
Milestone
0.11
Development

Successfully merging a pull request may close this issue.

feat: add ability to mark MBR partition bootable Unix4ever/talos
2 participants
@smira @Unix4ever