Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diskSelector fails to find disk using only size #3572

Closed
TimJones opened this issue May 4, 2021 · 0 comments · Fixed by #3573
Closed

diskSelector fails to find disk using only size #3572

TimJones opened this issue May 4, 2021 · 0 comments · Fixed by #3573

Comments

@TimJones
Copy link
Member

TimJones commented May 4, 2021 •
edited
Loading

Bug Report

Description

In my Talos config I have

  install:
    diskSelector:
      size: '<= 256GB'

but when booting the machine, it fails to find a disk with

[talos] task loadConfig (1/1): failed: failed to parse config: deprecated decode: unknown binary operator <= 256GB

Logs

See above.

Environment

  • Talos version: v0.10.0
  • Kubernetes version: v1.21.0
  • Platform: metal (using Sidero)
Unix4ever added a commit to Unix4ever/talos that referenced this issue May 4, 2021
@Unix4ever
fix: properly parse matcher expressions
97889c6 
Fixes: siderolabs#3572

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
Unix4ever added a commit to Unix4ever/talos that referenced this issue May 4, 2021
@Unix4ever
fix: properly parse matcher expressions
e6c130c 
Fixes: siderolabs#3572

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
@Unix4ever Unix4ever mentioned this issue May 4, 2021
Merged
talos-bot pushed a commit that referenced this issue May 4, 2021
@Unix4ever @talos-bot
fix: properly parse matcher expressions
3823909 
Fixes: #3572

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
smira pushed a commit to smira/talos that referenced this issue May 5, 2021
@Unix4ever @smira
fix: properly parse matcher expressions
66017cd 
Fixes: siderolabs#3572

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
(cherry picked from commit 3823909)
smira pushed a commit to smira/talos that referenced this issue May 5, 2021
@Unix4ever @smira
fix: properly parse matcher expressions
2536be1 
Fixes: siderolabs#3572

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
(cherry picked from commit 3823909)
smira pushed a commit that referenced this issue May 5, 2021
@Unix4ever @smira
fix: properly parse matcher expressions
194baa3 
Fixes: #3572

Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com>
(cherry picked from commit 3823909)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: properly parse matcher expressions Unix4ever/talos
1 participant
@TimJones