Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes for protobuf encoding #6057

Closed
13 tasks done
DmitriyMV opened this issue Aug 10, 2022 · 0 comments
Closed
13 tasks done

Various fixes for protobuf encoding #6057

DmitriyMV opened this issue Aug 10, 2022 · 0 comments
Assignees
@DmitriyMV
Labels
kind/bug

Comments

@DmitriyMV
Copy link
Member

DmitriyMV commented Aug 10, 2022 •
edited
Loading

TODO list (after this PR):

  • x509 - figure out proper encoding via x509 package
  • netaddr.* - figure out proper binary encoding even if we don't do netip transition now

Originally posted by @smira in #6024 (review)

Also:

  • fix SeccompProfileSpec support (support map[string]interface{} in protoenc package)
  • fix AdmissionPluginSpec support (support map[string]interface{} in protoenc package)
  • fix KubeletConfigSpec support (support map[string]interface{} in protoenc package)
  • fix ManifestSpec support (support map[string]interface{} in protoenc package)
  • fix StaticPodSpec support (support map[string]interface{} in protoenc package)
  • fix StaticPodStatusSpec support (support map[string]interface{} in protoenc package)
  • fix KubeletSpecSpec support (support map[string]interface{} in protoenc package)
  • fix AdmissionControlConfig support (support map[string]interface{} in protoenc package)
  • fix KubernetesRootSpec - add *x509.PEMEncodedKey encoder
  • Redo custom encoders/decoders as they currently using values instead of pointers

Also also:
@DmitriyMV DmitriyMV mentioned this issue Aug 10, 2022
Merged
talos-bot pushed a commit to siderolabs/protoenc that referenced this issue Aug 10, 2022
@DmitriyMV
chore: add support for map[string]interface{}
49a85fa 
For siderolabs/talos#6057

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@DmitriyMV DmitriyMV self-assigned this Aug 10, 2022
@DmitriyMV DmitriyMV mentioned this issue Aug 10, 2022
Merged
talos-bot pushed a commit to siderolabs/protoenc that referenced this issue Aug 10, 2022
@DmitriyMV
fix: support pointer to structs in marshal/unmarshal
3e56913 
For siderolabs/talos#6057

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DmitriyMV DmitriyMV

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DmitriyMV