fix: add a check for overlay mounts in installer pre-flight checks #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
smira
force-pushed
the
install-overlay-check
branch
from
324368e
to
4d2e2de
Compare
|
/rebase |
talos-bot
force-pushed
the
install-overlay-check
branch
from
4d2e2de
to
04e5bbf
Compare
smira
added a commit
to smira/talos
that referenced
this pull request
Apr 2, 2021
Container rootfs should be writeable as containerd mounts standard filesystems `/proc` et al. When `/opt` was used as a root of container filesystem this results in a problem: Talos overlay mounts `/opt` on `/var/system` which means that as long as `apid` running `/var` can't be unmounted which breaks upgrades. So instead use `/system/libexec` as rootfs for the containers, `/system` is `tmpfs`, and bind-mount actualy executable (`/sbin/init`, machined) into rootfs. This fixes upgrades for 0.10. See also siderolabs#3425 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Apr 2, 2021
Container rootfs should be writeable as containerd mounts standard filesystems `/proc` et al. When `/opt` was used as a root of container filesystem this results in a problem: Talos overlay mounts `/opt` on `/var/system` which means that as long as `apid` running `/var` can't be unmounted which breaks upgrades. So instead use `/system/libexec` as rootfs for the containers, `/system` is `tmpfs`, and bind-mount actually executable (`/sbin/init`, machined) into rootfs. This fixes upgrades for 0.10. See also siderolabs#3425 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
smira
force-pushed
the
install-overlay-check
branch
from
04e5bbf
to
52bbc9f
Compare
talos-bot
pushed a commit
that referenced
this pull request
Apr 2, 2021
Container rootfs should be writeable as containerd mounts standard filesystems `/proc` et al. When `/opt` was used as a root of container filesystem this results in a problem: Talos overlay mounts `/opt` on `/var/system` which means that as long as `apid` running `/var` can't be unmounted which breaks upgrades. So instead use `/system/libexec` as rootfs for the containers, `/system` is `tmpfs`, and bind-mount actually executable (`/sbin/init`, machined) into rootfs. This fixes upgrades for 0.10. See also #3425 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
|
/rebase |
talos-bot
force-pushed
the
install-overlay-check
branch
from
52bbc9f
to
6b88910
Compare
Overlay mount in `mountinfo` don't show up as mounts for any particular block device, so the existing check doesn't catch them. This was discovered as our current master can't upgrade because of overlay mount for `/opt` and `apid` image in `/opt/apid` (which will be fixed in a separate PR). Without the check, installer fails on resetting partition table for the disk effectively wiping the node (`device or resource busy` error). Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
smira
force-pushed
the
install-overlay-check
branch
from
6b88910
to
ecdcf82
Compare
andrewrynhard
approved these changes
Apr 5, 2021
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overlay mount in
mountinfodon't show up as mounts for any particularblock device, so the existing check doesn't catch them.
This was discovered as our current master can't upgrade because of
overlay mount for
/optandapidimage in/opt/apid(which will befixed in a separate PR).
Without the check, installer fails on resetting partition table for the
disk effectively wiping the node (
device or resourse busyerror).Signed-off-by: Andrey Smirnov smirnov.andrey@gmail.com