Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop networkd before leaving etcd on 'reset' path #3590

Merged
merged 1 commit into from
May 7, 2021
Merged

fix: stop networkd before leaving etcd on 'reset' path #3590

merged 1 commit into from
May 7, 2021

Commits on May 7, 2021

  1. fix: stop networkd before leaving etcd on 'reset' path 

    The problem is with VIP and `reset` sequence: the order of operations
was that `etcd` was stopped first while `networkd` was still running,
and if the node owned the VIP at the time of the reset action, the lease
will be lost (as client connection is gone), so VIP will be unassigned
for a pretty long time.

This PR changes the order of operations: first, stop `networkd` and
other pods, and leave `etcd` last, so that VIP is released, and
`kube-apiserver` for example isn't left hanging on the node while `etcd`
is gone.

Fixes siderolabs#3500

Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
    @smira
    smira committed May 7, 2021
    Configuration menu
    Copy the full SHA
    63e3768 View commit details
    Browse the repository at this point in the history