chore: update RBAC rules, remove old APIs #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
AlekSi
commented
Jun 18, 2021
| @@ -141,8 +141,6 @@ FROM build AS generate-build | |||
| COPY ./api/vendor/ /api/vendor/ | |||
| COPY ./api/common/common.proto /api/common/common.proto | |||
| RUN protoc -I/api -I/api/vendor/ --go_out=paths=source_relative:/api --go-grpc_out=paths=source_relative:/api common/common.proto | |||
| COPY ./api/health/health.proto /api/health/health.proto | |||
| RUN protoc -I/api -I/api/vendor/ --go_out=paths=source_relative:/api --go-grpc_out=paths=source_relative:/api health/health.proto | |||
There was a problem hiding this comment.
It wasn't hooked to anything
| @@ -68,9 +68,9 @@ service MachineService { | |||
| rpc Restart(RestartRequest) returns (RestartResponse); | |||
| rpc Rollback(RollbackRequest) returns (RollbackResponse); | |||
| rpc Reset(ResetRequest) returns (ResetResponse); | |||
| rpc Recover(RecoverRequest) returns (RecoverResponse); | |||
There was a problem hiding this comment.
It did nothing since Talos 0.9
| rpc RemoveBootkubeInitializedKey(google.protobuf.Empty) | ||
| returns (RemoveBootkubeInitializedKeyResponse); | ||
| rpc RemoveBootkubeInitializedKey(google.protobuf.Empty) returns (RemoveBootkubeInitializedKeyResponse) { | ||
| option deprecated = true; |
There was a problem hiding this comment.
Not removed yet, but documented as deprecated
|
|
||
| "/time.TimeService/Time": role.MakeSet(role.Admin, role.Reader), | ||
| "/time.TimeService/TimeCheck": role.MakeSet(role.Admin, role.Reader), | ||
| } |
There was a problem hiding this comment.
I now wonder if we need prefix handling at all. Maybe it would be better to require all methods there in full
| @@ -167,6 +176,10 @@ func NewServer(r Registrator, setters ...Option) *grpc.Server { | |||
| server := grpc.NewServer(opts.ServerOptions...) | |||
| r.Register(server) | |||
|
|
|||
| if opts.Reflection { | |||
| reflection.Register(server) | |||
There was a problem hiding this comment.
Might be useful in the future, but not enabled now
Refs siderolabs#3421. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
smira
approved these changes
Jun 18, 2021
|
What was the health api used for? |
It was used in now gone |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3421.
This change is