Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Install for imager overlays #8383

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

frezbo
Copy link
Member

@frezbo frezbo commented Feb 29, 2024

Implement Install for imager overlays.
Also add support for generating installers.

Depends on: #8377

Fixes: #8350
Fixes: #8351
Fixes: #8350

@frezbo frezbo force-pushed the feat/imager-overlay-install branch 3 times, most recently from e0d2dbf to b00f301 Compare March 1, 2024 15:31
@frezbo frezbo force-pushed the feat/imager-overlay-install branch 4 times, most recently from 02941ce to e975d90 Compare March 8, 2024 12:04
@frezbo frezbo force-pushed the feat/imager-overlay-install branch from e975d90 to ebb746c Compare March 11, 2024 13:04
@frezbo frezbo force-pushed the feat/imager-overlay-install branch from ebb746c to db11fef Compare March 12, 2024 11:01
@smira
Copy link
Member

smira commented Mar 12, 2024

As a result of these changes, I guess make sbcs should be broken, so we should remove it everywhere (?)

And we should drop SBC assets from the release step in Drone

@frezbo frezbo force-pushed the feat/imager-overlay-install branch 7 times, most recently from ff08e28 to 87c452d Compare March 12, 2024 16:21
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume documentation update will be another PR?

@smira
Copy link
Member

smira commented Mar 12, 2024

probably we need at least a note in hack/release.toml for an alpha release that SBC images are not supported at the moment

@frezbo
Copy link
Member Author

frezbo commented Mar 12, 2024

probably we need at least a note in hack/release.toml for an alpha release that SBC images are not supported at the moment

yeh, I can add that, docs can be another PR

Implement `Install` for imager overlays.
Also add support for generating installers.

Depends on: siderolabs#8377

Fixes: siderolabs#8350
Fixes: siderolabs#8351
Fixes: siderolabs#8350

Signed-off-by: Noel Georgi <git@frezbo.dev>
@frezbo frezbo force-pushed the feat/imager-overlay-install branch from 87c452d to d118a85 Compare March 12, 2024 17:16
@frezbo
Copy link
Member Author

frezbo commented Mar 12, 2024

/m

@talos-bot talos-bot merged commit d118a85 into siderolabs:main Mar 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Talos Imager: support overlays Imager Overlay specification
3 participants