Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase host dns packet ttl for pods #8737

Merged
merged 1 commit into from
May 15, 2024

Conversation

DmitriyMV
Copy link
Member

This PR fixes incorrect packet TTL if forwardKubeDNSToHost is enabled.

Credits go to Julian Wiedmann.

Closes #8698.

@smira
Copy link
Member

smira commented May 14, 2024

This should be a fix:, not chore:, and we should probably first test it with forwardKubeDNSToHost enabled (via another non-backportable PR).

@DmitriyMV DmitriyMV changed the title chore: fix incorrect ttl for pods fix: increase host dns packet ttl for pods May 14, 2024
@DmitriyMV
Copy link
Member Author

DmitriyMV commented May 14, 2024

we should probably first test it with forwardKubeDNSToHost enabled (via another non-backportable PR).

@smira done in #8717

@julianwiedmann
Copy link

Thank you! All praise goes to @ayuspin, his debugging made it very easy :)

go.mod Outdated Show resolved Hide resolved
@DmitriyMV DmitriyMV force-pushed the fix-ttl branch 3 times, most recently from 1b45c56 to 885c489 Compare May 15, 2024 14:08
This PR fixes incorrect packet TTL if `forwardKubeDNSToHost` is enabled.

Credits go to Julian Wiedmann.
Closes siderolabs#8698.

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@DmitriyMV
Copy link
Member Author

/promote e2e-misc

@DmitriyMV
Copy link
Member Author

/promote integration-misc

@DmitriyMV
Copy link
Member Author

/m

@talos-bot talos-bot merged commit 53f5489 into siderolabs:main May 15, 2024
19 checks passed
@DmitriyMV DmitriyMV deleted the fix-ttl branch May 15, 2024 17:04
@smira smira mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backported
Development

Successfully merging this pull request may close these issues.

1.7.1 with hostdns and forwardKubeDNSToHost doesn't resolve anything
4 participants