feat: provide an option to enforce SecureBoot for TPM enrollment #9005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
feat/force-secureboot
branch
from
78aaf61
to
7eeba53
Compare
smira
commented
Jul 11, 2024
website/content/v1.8/reference/configuration/v1alpha1/config.md
Outdated
Show resolved
Hide resolved
frezbo
reviewed
Jul 11, 2024
internal/pkg/encryption/keys/tpm2.go
Outdated
| } | ||
|
|
||
| if efi.GetSetupMode() { | ||
| return nil, nil, fmt.Errorf("failed to enroll the TPM2 key, as the system is in setup mode") |
There was a problem hiding this comment.
i'm confused on the error message
There was a problem hiding this comment.
SecureBoot enabled, but setup mode is enabled?
There was a problem hiding this comment.
ahh now makes sense, since this has nothing to do with tpm2 enrollment, we could say not continuing due to secureboot enforcement check
There was a problem hiding this comment.
yes, thanks, I will update the message as well
Fixes siderolabs#8995 There is no security impact, as the actual SecureBoot state/configuration is measured into the PCR 7 and the disk encryption key unsealing is tied to this value. This is more to provide a way to avoid accidentally encrypting to the TPM while SecureBoot is not enabled. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
feat/force-secureboot
branch
from
7eeba53
to
cf5effa
Compare
frezbo
approved these changes
Jul 12, 2024
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Jul 17, 2024
Follow up for siderolabs#9005 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Jul 17, 2024
Follow up for siderolabs#9005 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8995
There is no security impact, as the actual SecureBoot state/configuration is measured into the PCR 7 and the disk encryption key unsealing is tied to this value.
This is more to provide a way to avoid accidentally encrypting to the TPM while SecureBoot is not enabled.