Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pushtotalk type push notification #235

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

deltapath-eric
Copy link
Contributor

Hi

First of all thanks for the effort on this great library.

Currently i have some usage on push to talk which required the push type of pushtotalk.
it would be great if you can merge the following changes.

Thanks!
Eric

@deltapath-eric
Copy link
Contributor Author

Hi @sideshow

is there any chance that you can help to review and merge with release on this change set?
Thank you for your time!

Eric

@coveralls
Copy link

coveralls commented Oct 23, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 56a335a on deltapath-eric:master
into b1e286b on sideshow:master.

@deltapath-eric deltapath-eric changed the title Fix n.Expiration.IsZero and support pushtotalk push notification Support pushtotalk type push notification Oct 24, 2024
@deltapath-eric
Copy link
Contributor Author

further updated the changes to sync with master
thanks!

@sideshow
Copy link
Owner

Thanks for the PR @deltapath-eric

@sideshow sideshow merged commit 8c41117 into sideshow:master Oct 24, 2024
7 checks passed
@deltapath-eric
Copy link
Contributor Author

Thanks for merging, hope we can have a new release soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants