-
-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typeCast): ensure the same behavior for field.string()
with query
and execute
#2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2820 +/- ##
==========================================
+ Coverage 90.33% 90.34% +0.01%
==========================================
Files 71 71
Lines 15731 15749 +18
Branches 1344 1350 +6
==========================================
+ Hits 14210 14228 +18
Misses 1521 1521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7 tasks
This was referenced Jul 22, 2024
This was referenced Jul 23, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a breaking change reported in Sequelize (sequelize/sequelize#17141) after introducing
typeCast
for execute method.Following the same approach of PR #2398, this PR ensures that the
typeCast
usage for bothquery
andexecute
methods are strictly equivalent when usingfield.string()
.To illustrate it better:
field.string()
.From Sequelize
For everyone that uses the
bind
option, MySQL2 3.9.0 causes a break changing, even if the user doesn't usetypeCast
:repro.js
bind
.From MySQL2
To get the same behavior with MySQL2, just use
field.string
fromtypeCast
with specific column types:After this PR 🧙🏻
Sequelize +
bind
option:MySQL2:
Note
next()
, only withfield.string()
.typeCast
usage.