Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #25 #26

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Fix #25 #26

merged 4 commits into from
Apr 12, 2024

Conversation

Pantamis
Copy link

Fix #25 which is a regression introduced by #22

A where clause was missing when implementing From<T> for JsValue in #22

I had to craft it since the #where_clause used in expand_into_wasm_abi is on Self which could only work for the Into<JsValue> trait implementation.

I still get an annoying warning field comments is never read when compiling but I am not sure if this comes from PR #22

@siefkenj
Copy link
Owner

Thanks for the fix!

You'll notice a new directory tests-e2e. Could you please create a new subfolder test3/ (you can do so by copying test1/) and put

#[derive(serde::Serialize, tsify_next::Tsify)]
#[tsify(into_wasm_abi)]
pub struct Identified<Id, Value> {
    pub id: Id,
    pub value: Value,
}

into the test? This will ensure the CI catches any compiler errors in the future.

@Pantamis
Copy link
Author

Done !

Nice to have e2e test now !

@siefkenj siefkenj merged commit 04db4ac into siefkenj:main Apr 12, 2024
3 checks passed
@Pantamis Pantamis deleted the fix_regression_22 branch April 12, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: into_wasm_abi requiring unnecessary trait bound
2 participants