Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25 which is a regression introduced by #22
A where clause was missing when implementing
From<T> for JsValue
in #22I had to craft it since the
#where_clause
used inexpand_into_wasm_abi
is onSelf
which could only work for theInto<JsValue>
trait implementation.I still get an annoying warning
field comments is never read
when compiling but I am not sure if this comes from PR #22