Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI errors #47

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Fix CI errors #47

merged 3 commits into from
Nov 18, 2024

Conversation

todays-mitsui
Copy link

@todays-mitsui todays-mitsui commented Nov 18, 2024

I found that the workflow is failing on the main branch. I am proposing the following fixes to ensure the workflow passes again:

  • Updated the snapshot of tests/expandtest.rs
    • 807a3ea
    • There seemed to be a difference in the generated code due to a Rust version upgrade
    • I ran MACROTEST=overwrite cargo test
  • Explicitly specified the Node.js version
    • 455ec6b
    • I used actions/setup-node@v4 to specify version v20
  • Updated the snapshot of the e2e tests
    • 0f426b8
    • It seems that spaces were unintentionally removed

I have confirmed that the workflow passes after running it on the forked repository.
todays-mitsui#3

@todays-mitsui todays-mitsui marked this pull request as ready for review November 18, 2024 00:42
@siefkenj siefkenj merged commit 9cb9563 into siefkenj:main Nov 18, 2024
3 checks passed
@siefkenj
Copy link
Owner

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants