Refine and fix bugs about firmware update tool and watchdog issue #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-kiszka
reviewed
Mar 25, 2024
...nel/linux/files/patches-6.1/0097--arm64-dts-ti-iot2050-Disable-lock-step-for-all-iot20.patch
Show resolved
Hide resolved
jan-kiszka
reviewed
Mar 25, 2024
recipes-bsp/u-boot/files/0011-arm-dts-iot2050-Disable-lock-step-mode-for-all-iot20.patch
Show resolved
Hide resolved
jan-kiszka
reviewed
Mar 25, 2024
|
|
||
| if __name__ == '__main__': | ||
| CODE = main(sys.argv[1:]) | ||
| sys.exit(CODE) |
There was a problem hiding this comment.
missing newline at EOF
jan-kiszka
reviewed
Mar 25, 2024
| # COPYING.MIT file in the top-level directory. | ||
| # | ||
|
|
||
| DESCRIPTION = "Module Firmware Update Scripts" |
There was a problem hiding this comment.
What is is "Module" in this context?
huaqianli
force-pushed
the
lee/after-270
branch
2 times, most recently
from
da9ac14
to
650ceda
Compare
jan-kiszka
reviewed
Mar 25, 2024
| # COPYING.MIT file in the top-level directory. | ||
| # | ||
|
|
||
| DESCRIPTION = "Customized Module(Special DI) Firmware Update Scripts" |
There was a problem hiding this comment.
At what is "Special DI" now?
There was a problem hiding this comment.
IOT2050 Customized external signal module, such as SM SENS DI. This kind of module is not PLC1200 standard, but "customized" by IOT2050. Hence such module could not be upgraded within the PLC ecosystem, but we have to provide method to support the FW upgrading for them.
jan-kiszka
reviewed
Mar 25, 2024
| @@ -35,6 +35,7 @@ IMAGE_INSTALL += " \ | |||
| customizations-example \ | |||
| switchserialmode \ | |||
| iot2050-firmware-update \ | |||
| iot2050-module-firmware-update \ | |||
There was a problem hiding this comment.
I don't get the commit message in line with with addition of the "module" update package to the image.
huaqianli
force-pushed
the
lee/after-270
branch
2 times, most recently
from
94863b1
to
63ca419
Compare
huaqianli
force-pushed
the
lee/after-270
branch
2 times, most recently
from
5f17d1a
to
68cbe5b
Compare
huaqianli
changed the title
jan-kiszka
reviewed
Apr 7, 2024
| @@ -0,0 +1,87 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
First sentence of the commit message seems to lack a verb.
jan-kiszka
reviewed
Apr 7, 2024
| except (IOError, TypeError): | ||
| self.firmware = firmware | ||
| if not hasattr(firmware, 'read'): | ||
| raise UpgradeError("TypeError: firmware must be a file-like object!") |
There was a problem hiding this comment.
nit: isinstance(firmware, io.IOBase) would be more accurate.
jan-kiszka
reviewed
Apr 7, 2024
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| unittest.main() |
There was a problem hiding this comment.
When and how will those unit tests be run?
huaqianli
force-pushed
the
lee/after-270
branch
2 times, most recently
from
e5561dc
to
3554601
Compare
huaqianli
force-pushed
the
lee/after-270
branch
2 times, most recently
from
0563c85
to
59b6935
Compare
BaochengSu
reviewed
May 30, 2024
BaochengSu
reviewed
May 30, 2024
recipes-devtools/firmware-update-package/files/iot2050-generate-fwu-tarball.sh
Outdated
Show resolved
Hide resolved
BaochengSu
reviewed
May 30, 2024
recipes-app/iot2050-module-firmware-update/files/iot2050-module-firmware-update.tmpl
Outdated
Show resolved
Hide resolved
BaochengSu
reviewed
May 30, 2024
recipes-app/iot2050-firmware-update/files/iot2050-firmware-update.tmpl
Outdated
Show resolved
Hide resolved
The uboot envs "m2_manual_config" and "watchdog_timeout_ms" should be preserved during the u-boot firmware update Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>
A PG1 A variant of the iot2050 series has been identified which partially lacks support for lock-step mode. This implies that not all iot2050 boards can support this mode. As a result, lock-step mode has been disabled across all iot2050 boards for consistency and to avoid potential issues. Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>
The PG1 A variant of the iot2050 series has been identified which partially lacks support for lock-step mode. This implies that all iot2050 boards can't support this mode. As a result, lock-step mode has been disabled across all iot2050 boards for consistency and to avoid potential issues. Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>
For better compatibility, use bytes instead of path string to transfer binary, and enhance the code scalability. Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>
The IOT2050 features a customized external signal module, such as the SM SENS DI. Unlike the standard PLC1200, this module is specifically tailored to the IOT2050's requirements. As a result, it cannot be upgraded within the conventional PLC ecosystem. However, we ensure to provide a method to support firmware upgrades for these custom modules. And the firmware update for the module should not be included with the image. This is because the image becomes too large and cumbersome to release when only the update tool needs to be released. Instead, the module firmware update should be packaged separately in its own Debian package for a more efficient and manageable release process. Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>
This commit addresses two issues: 1. Fixed two bugs in destruction of classes. It was trying to release a non-existent object, causing an error. This has been corrected. 2. Removed an unnecessary pattern from the Firmware class. This pattern was not contributing to the functionality of the class and was causing confusion. Its removal simplifies the class. Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>
BaochengSu
reviewed
Jun 5, 2024
BaochengSu
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iot2050-firmware-update: Fix bug in class destruction and refactor code
iot2050-module-firmware-update: Add module firmware update
iot2050-eio-manager: Refine the firmware update code
linux: Disable lock-step for all iot2050 boards
u-boot: Disable lock-step mode for all iot2050 boards
firmware-update-package: Add two more default uboot envs